Skip to content

test: adds pr permissions to bot#29923

Merged
christopherferreira9 merged 2 commits into
mainfrom
cferreira/fix-fixtures-bot-permissions
May 8, 2026
Merged

test: adds pr permissions to bot#29923
christopherferreira9 merged 2 commits into
mainfrom
cferreira/fix-fixtures-bot-permissions

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented May 8, 2026

Description

This PR adds missing permissions for pull-requests to update fixtures that is currently failing with 403.

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensys.slack.com/archives/CBW7S9FSN/p1778252290987909?thread_ts=1778240496.951059&cid=CBW7S9FSN

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: only adjusts GitHub Actions job permissions for the comment-triggered dispatcher, with no application/runtime code changes.

Overview
Fixes the Update E2E Fixtures workflow’s comment-triggered dispatch job by explicitly granting actions: write and pull-requests: write (plus contents: read) permissions.

This allows the bot command (@metamaskbot update-mobile-fixture) to successfully re-dispatch the workflow onto the PR branch and post PR comments without hitting 403 permission errors.

Reviewed by Cursor Bugbot for commit d449d9d. Bugbot is set up for automated code reviews on this repo. Configure here.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner May 8, 2026 15:06
@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label May 8, 2026
@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@christopherferreira9 christopherferreira9 added the skip-e2e skip E2E test jobs label May 8, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit eb614f4. Configure here.

Comment thread .github/workflows/update-e2e-fixtures.yml
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.50%. Comparing base (4797726) to head (d449d9d).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #29923    +/-   ##
========================================
  Coverage   81.50%   81.50%            
========================================
  Files        5328     5339    +11     
  Lines      141146   141590   +444     
  Branches    32157    32272   +115     
========================================
+ Hits       115046   115410   +364     
- Misses      18239    18280    +41     
- Partials     7861     7900    +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christopherferreira9 christopherferreira9 removed the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 8, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

@christopherferreira9 christopherferreira9 added this pull request to the merge queue May 8, 2026
Merged via the queue into main with commit 455d908 May 8, 2026
102 of 103 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/fix-fixtures-bot-permissions branch May 8, 2026 16:07
@github-actions github-actions Bot locked and limited conversation to collaborators May 8, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.78.0 Issue or pull request that will be included in release 7.78.0 label May 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.78.0 Issue or pull request that will be included in release 7.78.0 size-XS skip-e2e skip E2E test jobs team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants